Support sql_calc_found_rows with limit in sharded keyspace#6680
Merged
harshit-gangal merged 17 commits intovitessio:masterfrom Sep 14, 2020
Merged
Support sql_calc_found_rows with limit in sharded keyspace#6680harshit-gangal merged 17 commits intovitessio:masterfrom
harshit-gangal merged 17 commits intovitessio:masterfrom
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
f210296 to
e26f979
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
approved these changes
Sep 11, 2020
harshit-gangal
commented
Sep 11, 2020
| ] | ||
| } | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
reset this file change.
Collaborator
There was a problem hiding this comment.
Hmm... Weird. On my machine, with 723fef02e checked out, that file has an extra line at the end, and git does not see any changes. Not sure what's going on...
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
e35553d to
7fc9762
Compare
f4d5188 to
7fc9762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support queries using
SQL_CALC_FOUND_ROWS. This is done by rewriting the queries according to https://dev.mysql.com/worklog/task/?id=12615:So, vtgate will plan these queries by first solving the original query, without the
SQL_CALC_FOUND_ROWSoption, and then following up with aCOUNT(*)query.will get be rewritten into two queries:
The first query will be used to return the results to the user, and the second will be used to save the found_rows state on the session in vtgate.