Skip to content

only take on simple dual queries in the vtgate #6666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshit-gangal merged 1 commit into from
Sep 3, 2020
Merged

only take on simple dual queries in the vtgate #6666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions go/vt/vtgate/planbuilder/select.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func (pb *primitiveBuilder) processSelect(sel *sqlparser.Select, outer *symtab)
}

func handleDualSelects(sel *sqlparser.Select, vschema ContextVSchema) (engine.Primitive, error) {
if !isOnlyDual(sel.From) {
if !isOnlyDual(sel) {
return nil, nil
}

Expand Down Expand Up @@ -191,11 +191,16 @@ func buildLockingPrimitive(sel *sqlparser.Select, vschema ContextVSchema) (engin
}, nil
}

func isOnlyDual(from sqlparser.TableExprs) bool {
if len(from) > 1 {
func isOnlyDual(sel *sqlparser.Select) bool {
if sel.Where != nil || sel.GroupBy != nil || sel.Having != nil || sel.Limit != nil || sel.OrderBy != nil {
// we can only deal with queries without any other subclauses - just SELECT and FROM, nothing else is allowed
return false
}
table, ok := from[0].(*sqlparser.AliasedTableExpr)

if len(sel.From) > 1 {
return false
}
table, ok := sel.From[0].(*sqlparser.AliasedTableExpr)
if !ok {
return false
}
Expand Down
18 changes: 18 additions & 0 deletions go/vt/vtgate/planbuilder/testdata/select_cases.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1349,6 +1349,24 @@
}
}

# don't filter on the vtgate
"select 42 from dual where false"
{
"QueryType": "SELECT",
"Original": "select 42 from dual where false",
"Instructions": {
"OperatorType": "Route",
"Variant": "SelectReference",
"Keyspace": {
"Name": "main",
"Sharded": false
},
"FieldQuery": "select 42 from dual where 1 != 1",
"Query": "select 42 from dual where false",
"Table": "dual"
}
}

# testing SingleRow Projection with arithmetics
"select 42+2"
{
Expand Down