Fix: Remove SetMaster Query Expectation from ERS Test#6617
Merged
deepthi merged 2 commits intovitessio:masterfrom Aug 24, 2020
Merged
Fix: Remove SetMaster Query Expectation from ERS Test#6617deepthi merged 2 commits intovitessio:masterfrom
deepthi merged 2 commits intovitessio:masterfrom
Conversation
…re because SetMaster calls happen in the background as best effort approach. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
deepthi
reviewed
Aug 24, 2020
| require.NoError(t, err) | ||
|
|
||
| assert.False(t, newMaster.FakeMysqlDaemon.ReadOnly, "newMaster.FakeMysqlDaemon.ReadOnly set") | ||
| // old master read-only flag doesn't matter, it is scrapped |
Collaborator
There was a problem hiding this comment.
This comment isn't valid any more, let us remove it too.
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
deepthi
approved these changes
Aug 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an expectation that we can know for sure what the queries will be on replicas in an ERS situation.
SetMastercalls are done in the background as a best effort approach, so we can only check for error, and the query list of the new master.