Reverse workflow: update cells/tablet_types#6556
Merged
deepthi merged 1 commit intovitessio:masterfrom Aug 17, 2020
Merged
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
deepthi
suggested changes
Aug 13, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
The implementation looks fine. The only concern is whether it is valid to assume that the cells / tablet_types provided for the forward workflow are the same ones we should use for reverse.
Probably fine for the first implementation.
Can you please update the PR with a description of why this PR and a brief summary of implementation?
deepthi
approved these changes
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VReplication creates a reverse workflow on SwitchWrites so that it is possible to revert a MoveTables or Reshard. However the cell/tablet_types columns in _vt.vreplication are currently not updated with the options provided on the command line.
This PR fixes that:
target's cell (but not the source's) we use the source cell instead.
We chose this approach instead of adding more cli options to specify tablet_types/cells for the reverse workflow as a simpler initial implementation. We can add the extra options if we find valid use-cases for it.
Signed-off-by: Rohit Nayak rohit@planetscale.com