Lock Session Support#6517
Merged
harshit-gangal merged 14 commits intovitessio:masterfrom Aug 10, 2020
Merged
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
lock_session
branch
from
34a15f0 to
c7eeebe
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ions Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ysql Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Member
Author
|
All the end to end test are related to lock are working. I have updated the correct expectation for end to end test when a tx fails while holding a lock. Some unit test are pending for the new flow of ExecuteLock. |
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
reviewed
Aug 1, 2020
systay
reviewed
Aug 1, 2020
systay
reviewed
Aug 1, 2020
systay
reviewed
Aug 1, 2020
systay
approved these changes
Aug 1, 2020
Collaborator
systay
left a comment
systay
left a comment
There was a problem hiding this comment.
Nice stuff. Only nitpicks
sougou
approved these changes
Aug 2, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
LG. You can merge after comments are addressed.
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Collaborator
|
Review if anyone is looking for lock support in 7.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the lock function support relies on existing shard session within VTGate Session.
We will have a different Shard session called lock session to support this feature.
Locking and transaction are orthogonal and to not interfere with each other they need a separate code path to manage.