Merged
Conversation
So that this container can work with a non-host network Signed-off-by: <avovk@recurly.com> Signed-off-by: Artem Vovk <avovk@recurly.com>
9049a30 to
fca0764
Compare
dkhenry
approved these changes
Jul 30, 2020
Contributor
dkhenry
left a comment
There was a problem hiding this comment.
Looks like it will work under all circumstances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that this container can work with a non-host network
Signed-off-by: avovk@recurly.com
I have a docker network and MySQL running in a container on that network.
Using the following
docker run:I kept running into timeouts from
vtctlclient.Finally, identified that
hostname:portfor that command were not the ones wherevttabletwas listening.I retested this using
--network=<custom>and--network=host.