Merged
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
sysset-vitess-aware
branch
from
056e93f to
8469f1f
Compare
When evaluating expressions, MySQL has special rules when the expression is on the RHS of a system setting that is a boolean, such as: set autocommit = on In these cases, expressions that would have been handled as columns are instead treated as string literals. This change tries to mimic this behaviour. Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
sysset-vitess-aware
branch
from
4a948c5 to
bfef26e
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
sysset-vitess-aware
branch
from
dce2aee to
a1e1240
Compare
…error Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
requested changes
Aug 18, 2020
Comment on lines
69
to
70
| in: "@@session.x.foo = 42", | ||
| expected: "session `x.foo` = 42", |
Member
There was a problem hiding this comment.
same test cases added twice.
sougou
reviewed
Aug 20, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Looks good from eyeballing. I'll let @harshit-gangal do the nit-picking.
The PR does need a detailed comment.
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the planner so that we can plan
SETting system variables that change Vitess' behaviour. It's the last important part of SET planning that was missing.The settings that are now being handled by planning are: