Skip to content

add skip flag that can skip comparing source & destination schema when run splitdiff#6477

Merged
sougou merged 1 commit intovitessio:masterfrom
inolddays:addskipflaginsplitdiff
Aug 2, 2020
Merged

add skip flag that can skip comparing source & destination schema when run splitdiff#6477
sougou merged 1 commit intovitessio:masterfrom
inolddays:addskipflaginsplitdiff

Conversation

@inolddays
Copy link
Copy Markdown
Contributor

In splitClone state:
if source destination shard table has column like:
object_id varchar(128) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT ,
Then after copy and exec it on destination the table column will turn to like this:
object_id varchar(128) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT ,
In that case,(mysql's behavior) when source has too many tables contains columns as object_id.
there will be too much differ schema fail error out put on vtworkerclient side says:
remainder of the error is truncated because gRPC has a size limit on errors.
see the pic below:
image

This will obscure the real problem.
so add this flag assumed people already know the schema does not match and make the process going on

Signed-off-by: JohnnyThree whereshallyoube@gmail.com

…n do diff

Signed-off-by: JohnnyThree <whereshallyoube@gmail.com>
@inolddays inolddays requested a review from sougou as a code owner July 27, 2020 11:04
@sougou sougou merged commit c4054aa into vitessio:master Aug 2, 2020
@deepthi deepthi added this to the v8.0 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants