add skip flag that can skip comparing source & destination schema when run splitdiff#6477
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 2, 2020
Merged
Conversation
…n do diff Signed-off-by: JohnnyThree <whereshallyoube@gmail.com>
sougou
approved these changes
Aug 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In splitClone state:

if source destination shard table has column like:
object_idvarchar(128) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT ,Then after copy and exec it on destination the table column will turn to like this:
object_idvarchar(128) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT ,In that case,(mysql's behavior) when source has too many tables contains columns as
object_id.there will be too much differ schema fail error out put on vtworkerclient side says:
remainder of the error is truncated because gRPC has a size limit on errors.
see the pic below:
This will obscure the real problem.
so add this flag assumed people already know the schema does not match and make the process going on
Signed-off-by: JohnnyThree whereshallyoube@gmail.com