Vtexplain: migrate to new healthcheck#6460
Merged
harshit-gangal merged 3 commits intovitessio:masterfrom Jul 22, 2020
Merged
Conversation
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
force-pushed
the
ds-vtexplain-newhc
branch
from
2178aca to
2620e89
Compare
Signed-off-by: deepthi <deepthi@planetscale.com>
Collaborator
Author
|
Tests are in fact passing on GH Actions: https://github.com/vitessio/vitess/actions?query=branch%3Ads-vtexplain-newhc |
harshit-gangal
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6460 #6246
vtexplain will now use TabletGateway with the new healthcheck.
Also migrated vstream tests to use new healthcheck.