System Variables support using Reserved Connections#6459
Merged
harshit-gangal merged 23 commits intovitessio:masterfrom Jul 24, 2020
Merged
System Variables support using Reserved Connections#6459harshit-gangal merged 23 commits intovitessio:masterfrom
harshit-gangal merged 23 commits intovitessio:masterfrom
Conversation
systay
force-pushed
the
sysset-reserveconn
branch
from
73320d1 to
c90276a
Compare
harshit-gangal
force-pushed
the
sysset-reserveconn
branch
from
c90276a to
2abb221
Compare
systay
force-pushed
the
sysset-reserveconn
branch
from
2abb221 to
cca677d
Compare
harshit-gangal
force-pushed
the
sysset-reserveconn
branch
from
cd761d1 to
af84c3b
Compare
systay
force-pushed
the
sysset-reserveconn
branch
4 times, most recently
from
9999e34 to
f2e1748
Compare
sougou
approved these changes
Jul 24, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
This looks good overall. Not as scary as I originally expected because the groundwork for it is already in. I see that this is a superset of get_lock also, which means get_lock is also good.
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
…variables Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
force-pushed
the
sysset-reserveconn
branch
from
f2e1748 to
8ee2bb8
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
sysset-reserveconn
branch
from
8ee2bb8 to
05dd2fe
Compare
systay
force-pushed
the
sysset-reserveconn
branch
from
710e113 to
05dd2fe
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6107
This PR has some framework dependency on #6370