Skip to content

Replace ExecuteBatch call with Execute in VTGate#6431

Merged
systay merged 4 commits intovitessio:masterfrom
planetscale:replace-execBatchcall
Jul 13, 2020
Merged

Replace ExecuteBatch call with Execute in VTGate#6431
systay merged 4 commits intovitessio:masterfrom
planetscale:replace-execBatchcall

Conversation

@harshit-gangal
Copy link
Copy Markdown
Member

@harshit-gangal harshit-gangal commented Jul 9, 2020

Closes: #6407

For reviewer: There is change in vtexplain output for some of the test which looks right to me.

@harshit-gangal harshit-gangal requested a review from sougou July 9, 2020 21:51
@harshit-gangal harshit-gangal force-pushed the replace-execBatchcall branch from 6c13e2d to e175f0f Compare July 10, 2020 03:26
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal force-pushed the replace-execBatchcall branch from e175f0f to 002aba6 Compare July 10, 2020 05:50
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link
Copy Markdown
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@systay systay merged commit efbb499 into vitessio:master Jul 13, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Deprecate ExecuteBatch calls on autocommit mode in VTGate

3 participants