Schema Version Table: change ddl column to blob#6399
Merged
sougou merged 2 commits intovitessio:masterfrom Jul 2, 2020
Merged
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
sougou
reviewed
Jul 1, 2020
| pos VARBINARY(10000) NOT NULL, | ||
| time_updated BIGINT(20) NOT NULL, | ||
| ddl VARBINARY(1000) DEFAULT NULL, | ||
| ddl BLOB NOT NULL, |
Contributor
There was a problem hiding this comment.
I think it's safer to go with the ALTER approach and use the withddl package.
…nge. Updated tests: extra events can occur if tests are run isolated due to the way withddl works Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
changed the title
rohit-nayak-ps
changed the title
sougou
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit Nayak rohit@planetscale.com