Change how tracing information is deserialised#6398
Closed
systay wants to merge 1 commit intovitessio:masterfrom
Closed
Change how tracing information is deserialised#6398systay wants to merge 1 commit intovitessio:masterfrom
systay wants to merge 1 commit intovitessio:masterfrom
Conversation
Closed
Signed-off-by: Andres Taylor <andres@planetscale.com>
Collaborator
sougou
reviewed
Jul 1, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Are we parsing html headers here? If so, could we use an existing API?
Who creates these strings, and where's the code that creates it?
Collaborator
Author
|
This is not a good solution. Will re-open a new PR with a better approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.