Skip to content

rename and deprecate RPCs, rename vars and files#6392

Merged
sougou merged 1 commit intovitessio:masterfrom
planetscale:ds-rename-rpcs-vars
Jul 2, 2020
Merged

rename and deprecate RPCs, rename vars and files#6392
sougou merged 1 commit intovitessio:masterfrom
planetscale:ds-rename-rpcs-vars

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Jun 29, 2020

Signed-off-by: deepthi deepthi@planetscale.com

@deepthi deepthi requested review from morgo and sougou as code owners June 29, 2020 05:20
sougou
sougou reviewed Jul 1, 2020
View reviewed changes
@deepthi
rename and deprecate RPCs, rename vars and files
1acb6e0 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi force-pushed the ds-rename-rpcs-vars branch from 66bb2d5 to 1acb6e0 Compare July 2, 2020 18:25
@deepthi
Copy link
Copy Markdown
Collaborator Author

deepthi commented Jul 2, 2020 •
edited
Loading

@sougou this is ready for re-review.
Here's how I tested the proto changes:

  • Run vttablets in local example with new proto definitions
  • Start vtctld with older build (master w/o this PR changes)
  • test that ShardReplicationPositions works correctly. This tests the changes to replicationdata protobuf. I added more output locally to ShardReplicationPositions to validate the values of IoThreadRunning and SqlThreadRunning.
  • test ReparentTablet and PlannedReparentShard. These test the changes to SetMasterRequest where force_start_slave is being renamed to force_start_replication. One of them sends the value as false and one as true, so both possibilities are tested.
  • All these manual tests worked as expected. Verified by inspecting logs and cluster state.

@deepthi deepthi mentioned this pull request Jul 2, 2020
Merged
@deepthi deepthi requested review from acharis and zmagg July 2, 2020 19:17
@sougou sougou merged commit 03c5afd into vitessio:master Jul 2, 2020
@deepthi deepthi deleted the ds-rename-rpcs-vars branch July 6, 2020 18:59
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morgo morgo Awaiting requested review from morgo

@acharis acharis Awaiting requested review from acharis

@zmagg zmagg Awaiting requested review from zmagg

1 more reviewer

@sougou sougou sougou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@deepthi @sougou