orchestrator repo moved under openark/ org#6360
Merged
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
requested review from
derekperkins,
dkhenry and
sougou
as code owners
|
|
||
| echo "Building orchestrator..." | ||
| docker run -ti --name=vt_orc_build golang:1.7 bash -c "$script" | ||
| docker run -ti --name=vt_orc_build golang:1.14.4-stretch bash -c "$script" |
Member
There was a problem hiding this comment.
current vitess minimum version is 1.13. Do we want to keep that same here?
Member
There was a problem hiding this comment.
I'm not sure if this docker image is even being built or used anywhere
Contributor
Author
There was a problem hiding this comment.
I believe it is not being used officially. However, users who hav ecloned this repo locally may try and use it (it works).
Contributor
Author
There was a problem hiding this comment.
current vitess minimum version is 1.13.
Latest orchestrator has a go1.14 minimum requirement. I guess for 3.1.0 we can use 1.13 -- but now I notice this image uses an old version of orchestrator... I'll update that, too.
sougou
approved these changes
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orchestratorrepo used to be underhttps://github.com/github/and is now underhttps://github.com/openark/. At this time there is an implicit redirect from the former to the latter, but we shouldn't rely on that to continue. This PR updates any reference toorchestratorrepo to point into theopenark/org.Validated that
vitess/orchestrator:latestbuilds and runs correctly.