tabletserver: code simplification#6348
Merged
sougou merged 7 commits intovitessio:masterfrom Jun 24, 2020
Merged
Conversation
Contributor
sougou
commented
Jun 21, 2020
sougou
commented
- Simplify tracker initialization, and let it run its own vstream
- Simplify historian by making it a sub-component of schema engine
- Introduce a withddl package to simplify automatic schema upgrades
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Since the historian life cycle was the same as schema engine, it's now been made part of it. Its api is exposed by the engine itself. This also simplified the internal structure of the historian because it doesn't have to deal with the latest schema any more. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
withddl allows you to fix schema as it evolves over the versions. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
force-pushed
the
ss-historian-simple
branch
from
abb98f7 to
ef5f979
Compare
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.