Reserve connection protobuf changes#6303
Merged
sougou merged 1 commit intovitessio:masterfrom Jun 16, 2020
Merged
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
new-reserved-connections
branch
from
e787457 to
558625e
Compare
Closed
harshit-gangal
force-pushed
the
new-reserved-connections
branch
from
701b256 to
9d3b288
Compare
systay
force-pushed
the
new-reserved-connections
branch
from
9d3b288 to
558625e
Compare
deepthi
reviewed
Jun 15, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Can you link to the RFC for each of the reserved connection PRs?
| // CommitResponse is the returned value from Commit | ||
| message CommitResponse {} | ||
| message CommitResponse { | ||
| int64 reserved_id = 1; |
Collaborator
There was a problem hiding this comment.
Why do we need to return this for Commit and Rollback?
Contributor
There was a problem hiding this comment.
Because a commit will cause the id to change, to prevent reuse of ids.
sougou
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #6107
Signed-off-by: Harshit Gangal harshit@planetscale.com