Add flag to catch and ignore SIGPIPE#6297
Merged
sougou merged 1 commit intovitessio:masterfrom Jun 11, 2020
Merged
Conversation
Signed-off-by: Adam Saponara <as@php.net>
sougou
approved these changes
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go runtime catches SIGPIPE for us on all fds except stdout and stderr. (See https://golang.org/pkg/os/signal/#hdr-SIGPIPE.) This patch adds a flag that catches SIGPIPE not handled by the runtime, prints a warning, and then ignores all future SIGPIPEs.
In our case, we run Vitess components via systemd. journald was restarted at an unlucky time, causing vttablet to receive a SIGPIPE when trying to write to stderr. As explained above, the Go runtime does not catch SIGPIPE on stdout or stderr, so vttablet was killed.
As an additional note to anyone running systemd services, systemd bizarrely counts death by SIGPIPE (and a few other signals) to be a successful exit. That means you need to set
Restart=alwaysif you want your service to restart on SIGPIPE. (We had ours set toRestart=on-failureso the service did not restart.)Signed-off-by: Adam Saponara as@php.net