VReplication: allow foreign key constraints during copy#6284
Merged
sougou merged 3 commits intovitessio:masterfrom Jun 18, 2020
Merged
VReplication: allow foreign key constraints during copy#6284sougou merged 3 commits intovitessio:masterfrom
sougou merged 3 commits intovitessio:masterfrom
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
systay
reviewed
Jun 9, 2020
systay
reviewed
Jun 9, 2020
sougou
reviewed
Jun 15, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
I think this can be simpler:
- clearFKcheck should always set fk check to 0.
- resetFKCheckAfterCopy can always set it back to whatever value getSettingFKCheck got.
Also, those logs will need to be removed (or changed to V).
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Member
Author
updated as suggested, ptal |
sougou
approved these changes
Jun 18, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.