TestMessage: account for jitter#6283
Merged
sougou merged 2 commits intovitessio:masterfrom Jun 12, 2020
Merged
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
derekperkins
reviewed
Jun 9, 2020
Comment on lines
+145
to
+146
| if !(start+2e9 < next && next < (start+jitter)+6e9) { | ||
| t.Errorf("next: %d. must be about 3s after start: %d", next/1e9, (start+jitter)/1e9) |
Member
There was a problem hiding this comment.
Jitter would have happened twice here, so maxJitter would be epoch * 1.333
Member
Author
There was a problem hiding this comment.
Thanks, made the change to use epoch*maxJitter. There will no jitter in Epoch 0: is that correct?
Member
There was a problem hiding this comment.
// have backoff be +/- 33%, whenever this is injected, append (:min_backoff, :jitter)
jitteredBackoff := "FLOOR((%a<<ifnull(epoch, 0)) * %a)"
Correct, no jitter. By default, the jitter is also windowed around the min/max backoff. If there are no settings, minBackoff is the same as ackWaitTimeout and no limit on maxBackoff.
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
sougou
approved these changes
Jun 12, 2020
This was referenced Jun 18, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit Nayak rohit@planetscale.com