Merged
Conversation
We introduced an abstraction layer to be able to have the old and new executor side by side in the same code base. We never really used this capability and instead have been moving logic steadly from one to the other, and then removing the legacy code. Given this situation, the extra abstraction was just awkward to explain, and not at all helpful. This simplifies the code by removing unecessary abstractions and tests. Signed-off-by: Andres Taylor <andres@planetscale.com>
sougou
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced an abstraction layer to be able to have the old and new executor
side by side in the same code base. We never really used this capability and
instead have been moving logic steadly from one to the other, and then removing
the legacy code.
Given this situation, the extra abstraction was just awkward to explain, and not at all helpful.
This simplifies the code by removing unecessary abstractions and tests.