Test that vtexplain works with healthcheck#6252
Merged
deepthi merged 1 commit intovitessio:masterfrom Jun 1, 2020
Merged
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Collaborator
|
Thank you for adding this. I think the description as it was written was misleading, because to me it implied that vtexplain is using the new healthcheck, whereas we are merely making sure that it continues to work even though the default has been changed to the new healthcheck. I took the liberty of updating the description to reflect this nuance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit test that makes sure that vtexplain works well even though the default gateway and healthcheck have been switched to a new implementation. See #6248 and #6246