Materialize: Use ApplySchema for bulk schema change#6251
Merged
sougou merged 2 commits intovitessio:masterfrom Jun 2, 2020
Merged
Materialize: Use ApplySchema for bulk schema change#6251sougou merged 2 commits intovitessio:masterfrom
sougou merged 2 commits intovitessio:masterfrom
Conversation
teejae
force-pushed
the
tj-materialize-apply-schema
branch
2 times, most recently
from
2e0968d to
c545361
Compare
Signed-off-by: Toliver Jue <toliver@planetscale.com>
teejae
force-pushed
the
tj-materialize-apply-schema
branch
from
c545361 to
02be677
Compare
systay
approved these changes
Jun 1, 2020
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
approved these changes
Jun 2, 2020
Member
rohit-nayak-ps
left a comment
rohit-nayak-ps
left a comment
There was a problem hiding this comment.
Nice, code looks good.
Tests are all passing now.
Local examples worked after AllowReplication=true and other cluster test flakiness seem resolved after a few reruns ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Toliver Jue toliver@planetscale.com