java/vtgate-client: Process new "Flags" MySQL field in result set.#624
Merged
michael-berlin merged 1 commit intomasterfrom May 20, 2015
Merged
java/vtgate-client: Process new "Flags" MySQL field in result set.#624michael-berlin merged 1 commit intomasterfrom
michael-berlin merged 1 commit intomasterfrom
Conversation
This change breaks the previous behavior: Before, BIGINT values were always mapped to an UnsignedLong by default, unless they were negative. With this change, they will be a UnsignedLong or Long depending on the SQL schema (UNSIGNED flag present or not). If an old VtGate does not send the Flags field, such values will be mapped to a Long instead of an UnsignedLong before. Refactored "FieldType" enum and included it in the "Field" class.
michael-berlin
added a commit
that referenced
this pull request
May 20, 2015
java/vtgate-client: Process new "Flags" MySQL field in result set.
rsajwani
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 1, 2022
* Limit some log messages to once per 15s These two log messages are under the client's control: exceeding the maximum number of patterns to aggregate, and exceeding the Kafka buffer size. A very busy client may (intentionally or not) exceed these limits, and we don't want one log line per statement when that happens. So we keep a counter of overflows and log about it only at the end of a 15s interval. Other chatty log messages that aren't under the client's control are left intact here. In particular, Kafka errors, type-cast errors, and serialization errors are things where we'll want to see `err.Error()`, so we don't just roll them up as a uint. Signed-off-by: Patrick Reynolds <patrick@piki.org> * Fix `log.Infof` arguments Signed-off-by: Patrick Reynolds <patrick@piki.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change breaks the previous behavior: Before, BIGINT values were
always mapped to an UnsignedLong by default, unless they were negative.
With this change, they will be a UnsignedLong or Long depending on the
SQL schema (UNSIGNED flag present or not).
If an old VtGate does not send the Flags field, such values will be
mapped to a Long instead of an UnsignedLong before.
Refactored "FieldType" enum and included it in the "Field" class.
This commit was previously part of #618 and already LGTM'd. We'll merge it once the other commit went into production.