helm: simplified for examples#6168
Merged
sougou merged 5 commits intovitessio:masterfrom May 11, 2020
Merged
Conversation
Also add instructions for final teardown. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
| mysqlSize: "prod" | ||
| resources: | ||
| mysqlResources: | ||
| # It's generally not recommended to override this value for production usage. |
Member
There was a problem hiding this comment.
This comment line should probably get removed from all these examples because it's misleading
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
derekperkins
approved these changes
May 11, 2020
They don't eat into the resource budget Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helm launches many containers that are only relevant for prod. I've introduced a new topology parameter called
deploymentTypethat can be prod or test. If test, then those containers are not launched, and the resources for init containers is reduced to 10m.Also, the previous mysqlSize variable is deprecated in favor of this setting.