VStreamer: Schema versioning#6164
Conversation
fabc79f to
9e84108
Compare
sougou
left a comment
There was a problem hiding this comment.
Some feedback life-cycle management, which I forgot to ramp you up on.
Also, I think we can simplify historian's code as mentioned in the comment.
c5041ae to
c3e405b
Compare
sougou
left a comment
There was a problem hiding this comment.
Nice work. I added some nit-picks.
There was a problem hiding this comment.
Since sch doesn't escape out of this function, it's better to directly assign sch.Tables. No need to copy.
There was a problem hiding this comment.
sch.Tables is a list, converting to a map.
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
… optimize schema loads. Related tests. Fixed TestMessage race Signed-off-by: Rohit Nayak <rohit@planetscale.com>
6a00a90 to
81512fa
Compare
|
This implements rfc - #6300 From a Slack discussion -- Rohit mentioned
@rohit-nayak-ps What does on all replica tablets since any of them can become primary. |
No description provided.