Skip to content

VStreamer: Schema versioning#6164

Merged
sougou merged 17 commits intovitessio:masterfrom
planetscale:schema-versioning
May 31, 2020
Merged

VStreamer: Schema versioning#6164
sougou merged 17 commits intovitessio:masterfrom
planetscale:schema-versioning

Conversation

@rohit-nayak-ps
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback life-cycle management, which I forgot to ramp you up on.
Also, I think we can simplify historian's code as mentioned in the comment.

Copy link
Copy Markdown
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I added some nit-picks.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since sch doesn't escape out of this function, it's better to directly assign sch.Tables. No need to copy.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sch.Tables is a list, converting to a map.

systay and others added 17 commits May 31, 2020 00:16
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Rohit Nayak<rohit@planetscale.com>

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
… optimize schema loads. Related tests. Fixed TestMessage race

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@sougou sougou merged commit b28fb8f into vitessio:master May 31, 2020
@rohit-nayak-ps rohit-nayak-ps linked an issue Jun 10, 2020 that may be closed by this pull request
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@indera-shsp
Copy link
Copy Markdown
Contributor

indera-shsp commented Jul 1, 2021

This implements rfc - #6300

From a Slack discussion -- Rohit mentioned

If you stream from the primary the vstream will handle DDLs correctly. 
You should run the tracker on the primary. If you are streaming realtime then you don't need the tracker 
(the stream will pause while the latest schema is loaded), 
but if streams are run for older events then the tracker will provide the correct schema for the older events.

You should run the tracker on the primary

@rohit-nayak-ps What does primary mean here? My interpretation is that we should enable these two flags

-watch_replication_stream and -track_schema_versions

on all replica tablets since any of them can become primary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Tracking schema changes in vstreams

5 participants