Backport of USE and DATABASE() fix#6158
Merged
morgo merged 1 commit intovitessio:release-6.0from May 7, 2020
Merged
Conversation
Collaborator
systay
commented
May 7, 2020
systay
commented
- send use statement to vtgate instead of cominitdb method
- database() returns targetstring rather than keyspace
- remove cominitdb call with comquery with use statement
- return unknown db message on mysql connect to vtgate
- send use statement to vtgate instead of cominitdb method - database() returns targetstring rather than keyspace - remove cominitdb call with comquery with use statement - return unknown db message on mysql connect to vtgate Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
May 7, 2020
Member
harshit-gangal
left a comment
harshit-gangal
left a comment
There was a problem hiding this comment.
Can be merged if all tests go green :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.