vitessdriver: allow overriding the driver name#6138
Merged
sougou merged 1 commit intovitessio:masterfrom May 2, 2020
Merged
Conversation
Signed-off-by: Derek Perkins <derek@nozzle.io>
derekperkins
force-pushed
the
add-vitessdriver-config-option
branch
from
427e013 to
13437ec
Compare
sougou
approved these changes
May 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using https://github.com/opencensus-integrations/ocsql to wrap this driver for stats. It is necessary to use a custom driver name for that to work. Defaults haven't changed, so this should have no impact on any other users.