Reduce the number of packets sent from vttablet to MySQL#6130
Merged
sougou merged 1 commit intovitessio:masterfrom Apr 30, 2020
Merged
Reduce the number of packets sent from vttablet to MySQL#6130sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
using TCP by creating the write buffers with pre-allocated space for the header. Signed-off-by: Keyur Govande <keyur_govande@yahoo.com>
sougou
approved these changes
Apr 30, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Nice work. I would have personally considered thrashing the buffer in favor of simplicity, but no harm preserving the original bytes.
aquarapid
added a commit
to planetscale/vitess
that referenced
this pull request
May 31, 2020
…gth offset into account in writeBinaryRow(). Not an ideal fix, but something cleaner will involve invasive cleanup. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
added a commit
that referenced
this pull request
Jun 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create the write buffers with pre-allocated space for the header as well.
Signed-off-by: Keyur Govande keyur_govande@yahoo.com