Skip to content

Replace Sprintf by string concat in normalizer, reduces#6127

Merged
systay merged 1 commit intovitessio:masterfrom
planetscale:jacques_skip_sprintf
Apr 28, 2020
Merged

Replace Sprintf by string concat in normalizer, reduces#6127
systay merged 1 commit intovitessio:masterfrom
planetscale:jacques_skip_sprintf

Conversation

@aquarapid
Copy link
Copy Markdown
Contributor

vtgate CPU usage by 3-5% on QPS-heavy import benchmark.

Signed-off-by: Jacques Grove aquarapid@gmail.com

vtgate CPU usage by 3-5% on QPS-heavy import benchmark.

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
@aquarapid aquarapid requested a review from sougou as a code owner April 28, 2020 04:40
@sougou sougou requested review from harshit-gangal and systay April 28, 2020 04:43
Copy link
Copy Markdown
Member

@derekperkins derekperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an easy win!

Copy link
Copy Markdown
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@systay systay merged commit 14b4dac into vitessio:master Apr 28, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants