Add unit test for function in go/sync2/atomic.go#6120
Merged
sougou merged 1 commit intovitessio:masterfrom Apr 28, 2020
zouy414:UnitTest
Merged
Add unit test for function in go/sync2/atomic.go#6120sougou merged 1 commit intovitessio:masterfrom zouy414:UnitTest
sougou merged 1 commit intovitessio:masterfrom
zouy414:UnitTest
Conversation
sougou
reviewed
Apr 28, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
The new coding standard encourage tests to use assert. Would you be able to change these? Here's an example: https://github.com/vitessio/vitess/blob/master/go/vt/servenv/exporter_test.go#L103
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
Contributor
Author
|
@sougou , sorry for late reply, i have updated my code. |
sougou
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ZouYu zouy.fnst@cn.fujitsu.com