messenger: use ackWaitTimeout in postpone query#6114
Merged
sougou merged 2 commits intovitessio:masterfrom Apr 27, 2020
Merged
Conversation
without this, messages will be resent too quickly Signed-off-by: Derek Perkins <derek@nozzle.io>
this makes the postpone sql easier to follow, and it will make it easier to allow for user provided jitter % in the future Signed-off-by: Derek Perkins <derek@nozzle.io>
derekperkins
force-pushed
the
messages-ackWait
branch
from
6d1d03c to
06ab145
Compare
sougou
approved these changes
Apr 27, 2020
systay
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since messages are immediately postponed upon sending, we need to add exponential backoff on top of the ackWaitTime, otherwise messages will be resent too quickly.
This also simplifies the query by pulling out the
time_nowaddition to the front of the query and leaving the IF statement to only calculate backoff.In the second commit, I move the jitter calculation from SQL into Go. This makes the postpone sql easier to follow, and it will make it easier to allow for user provided jitter % in the future