Skip to content

helm: use proxy_tablets#6112

Merged
morgo merged 1 commit intovitessio:masterfrom
planetscale:ss-helm-vtctld-proxy
Apr 27, 2020
Merged

helm: use proxy_tablets#6112
morgo merged 1 commit intovitessio:masterfrom
planetscale:ss-helm-vtctld-proxy

Conversation

@sougou
Copy link
Copy Markdown
Contributor

@sougou sougou commented Apr 26, 2020

The redirect leads to a 404. However, adding a /debug/status to
the redirect URL does work. So, this is still an improvement.

I'll make a separate PR to append the /debug/status to the redirect
URL, which will fix this good. Then we'll have to build another helm
image.

Signed-off-by: Sugu Sougoumarane ssougou@gmail.com

The redirect leads to a 404. However, adding a /debug/status to
the redirect URL does work. So, this is still an improvement.

I'll make a separate PR to append the /debug/status to the redirect
URL, which will fix this good. Then we'll have to build another helm
image.

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo merged commit 52f48e7 into vitessio:master Apr 27, 2020
@sougou sougou deleted the ss-helm-vtctld-proxy branch April 28, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants