Skip to content

Fixed error message on database ddl query execution #6109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
systay merged 1 commit into from
Apr 24, 2020
Merged

Fixed error message on database ddl query execution #6109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion go/vt/vtgate/planbuilder/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,9 @@ func BuildFromStmt(query string, stmt sqlparser.Statement, vschema ContextVSchem
instruction, err = buildOtherReadAndAdmin(query, vschema)
case *sqlparser.Set:
instruction, err = buildSetPlan(query, stmt, vschema)
case *sqlparser.Show, *sqlparser.DBDDL, *sqlparser.SetTransaction:
case *sqlparser.DBDDL:
return nil, vterrors.Errorf(vtrpcpb.Code_UNIMPLEMENTED, "unsupported: Database DDL %v", sqlparser.String(stmt))
case *sqlparser.Show, *sqlparser.SetTransaction:
return nil, ErrPlanNotSupported
case *sqlparser.Begin, *sqlparser.Commit, *sqlparser.Rollback:
// Empty by design. Not executed by a plan
Expand Down
4 changes: 4 additions & 0 deletions go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,3 +411,7 @@
# delete with multi-table targets
"delete music,user from music inner join user where music.id = user.id"
"unsupported: multi-shard or vindex write statement"

# Database DDL
"create database foo"
"unsupported: Database DDL create database foo"