track how many times vstreaclient is opened and closed#6097
Closed
hihihuhu wants to merge 1 commit intovitessio:masterfrom
Closed
track how many times vstreaclient is opened and closed#6097hihihuhu wants to merge 1 commit intovitessio:masterfrom
hihihuhu wants to merge 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Chen Ding <dingc05@gmail.com>
Contributor
|
VStreamClient has been reworked on this branch: https://github.com/planetscale/vitess/tree/ss-vrepl-external. It will soon be submitted as a PR. It should address some of the concerns about too many connections, reconnections and subsequent schema reloads. If the problem persists after that, we can look at adding observability (or improvements) to vstreamer. |
Contributor
|
VStreamClient is now obsolete #6103. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VStreamerClientshares the connection whenOpenis called, however, each timeCloseis called, it closes the connection, and this causes problems in the resharding flow .The
VStreamerClientis opened forVStreamRowsincopyTable, then inside the loop, it is opened again for thefastForward. ThefastForwardwill close the client when it is done, however, a side effect is the connection forVStreamRowsis closed and the whole copy process is reset.So add a counter to the client and only close it when no one uses it anymore.