Refactor CRD to support K8s 1.15 specific requirements#6075
Merged
morgo merged 1 commit intovitessio:masterfrom Apr 16, 2020
Merged
Refactor CRD to support K8s 1.15 specific requirements#6075morgo merged 1 commit intovitessio:masterfrom
morgo merged 1 commit intovitessio:masterfrom
Conversation
K8s 1.15 added extra validation to CRD structure when using the v1beta1 api. The CRD has been restructured to conform to the new rules. Signed-off-by: Carson Anderson <ca@carsonoid.net>
morgo
approved these changes
Apr 16, 2020
Contributor
morgo
left a comment
There was a problem hiding this comment.
Manually tested on 1.15, LGTM
Contributor
|
The failing test will be fixed in #6076 I'm going to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
K8s 1.15 added extra validation to CRD structure when using
the v1beta1 api. The CRD has been restructured to conform
to the new rules.
I also moved the test to the v1beta1 api client.
Signed-off-by: Carson Anderson ca@carsonoid.net
I have manually validated that the crd below works for K8s 1.13, 1.14, 1.15 and 1.16:
This was the validation script:
Results: