Update query counts for stream queries from vtgate#6057
Merged
sougou merged 1 commit intovitessio:masterfrom Apr 13, 2020
Merged
Update query counts for stream queries from vtgate#6057sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Arka Ganguli <arkaganguli1@gmail.com>
arka-g
force-pushed
the
vtgate-stream-query-counts
branch
from
a6cc774 to
db90916
Compare
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 28, 2020
…ounts Update query counts for stream queries from vtgate
zmagg
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 29, 2020
…ounts Update query counts for stream queries from vtgate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We use the QueriesProcessedByTable metric to get visibility into the QPS per table. Currently, this metric does not get incremented in the stream query path. This PR handles that by incrementing query counts in the
StreamExecuteAPI.Testing
Manually tested by uploading the build to a vtgate and sent some olap mode queries via
set workload='olap';Signed-off-by: Arka Ganguli arkaganguli1@gmail.com