Merged
Conversation
Contributor
|
LGTM, I will update the docs |
Contributor
|
The examples all work for me (with 8GiB for minikube). May I suggest we update the alias to be 'mysql' instead of 'vmysql'. My docs currently assume this - if we use vmysql, then there will be more differences between the two. Unfortunately, the ~/.my.cnf file idea won't work because a script needs to be run. |
morgo
approved these changes
Apr 15, 2020
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
morgo
reviewed
Apr 15, 2020
morgo
reviewed
Apr 15, 2020
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
|
(Different unit tests failed 3 times due to flakyness, so I used admin overwrite to merge.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rohit-nayak-ps @morgo
The helm examples have been changed to use the new resharding commands.
Note the new README.md file. We don't need to run that many yaml upgrades any more. But I've kept them for now. We can delete them once the newer way of directly issuing "vclient" commands becomes the norm.
@rohit-nayak-ps: Note the different method I use for
MoveTablesthat doesn't require the extra steps of copying schema or applying vschema. Those parts are performed byMoveTablesitself. We should change the local example to use the same approach.We'll eventually have to update the cleanup steps once the
DropSourcescommand is implemented.