add recover in WatchSrvVSchema and GetSrvKeyspaceNames#6051
Merged
sougou merged 1 commit intovitessio:masterfrom Apr 12, 2020
xhh1989:master
Merged
add recover in WatchSrvVSchema and GetSrvKeyspaceNames#6051sougou merged 1 commit intovitessio:masterfrom xhh1989:master
sougou merged 1 commit intovitessio:masterfrom
xhh1989:master
Conversation
Signed-off-by: xuhaihua <xuhaihua@jd.com>
sougou
approved these changes
Apr 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The process of watch vschema adds Recover process. Because the watch is a little complicated and there will be callback . If the go routine panic caused by a invalid vschema data or other problems, then all vtgates may receive the same vschema and all vtgate will panic at the same time, which will be a disaster.