Skip to content

Fix the initial sharding flaky test#6043

Merged
sougou merged 1 commit intovitessio:masterfrom
planetscale:arindam_fix_for_flaky_test
Apr 13, 2020
Merged

Fix the initial sharding flaky test#6043
sougou merged 1 commit intovitessio:masterfrom
planetscale:arindam_fix_for_flaky_test

Conversation

@arindamnayak
Copy link
Copy Markdown
Contributor

@arindamnayak arindamnayak commented Apr 10, 2020

Fix for one more flaky test (which contains Too many connections error):

Error Trace:	base_sharding.go:151
        	            				base_sharding.go:351
        	            				base_sharding.go:323
        	            				sharding_util.go:495
        	Error:      	Expected nil, but got: &mysql.SQLError{Num:2012, State:"HY000", Message:"immediate error from server errorCode=1040 errorMsg=Too many connections", Query:""}
        	Test:       	TestInitialSharding

We were creating multiple connections in loop to insert and verify more than 2000 rows created by sharding test. This might be creating 'Too many connection' error. Now, the connection is created first and then passed around to insert/verify the rows

FYI @deepthi

Signed-off-by: Arindam Nayak arindam.nayak@outlook.com

@arindamnayak arindamnayak requested a review from sougou as a code owner April 10, 2020 09:53
We were creating multiple connection in loop to verify more than 2000 rows created by sharding test. This was creating 'Too many connection' error. Now, the connection is created first and then passed around to verify the rows

Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
@arindamnayak arindamnayak force-pushed the arindam_fix_for_flaky_test branch from 30b0403 to def32df Compare April 13, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants