tabletserver: refactor parameters#6020
Merged
sougou merged 8 commits intovitessio:masterfrom Apr 6, 2020
Merged
Conversation
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
Author
|
@rohit-nayak-ps may also review. |
deepthi
approved these changes
Apr 6, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Looks good except for one nit.
| DBConfigs() *dbconfigs.DBConfigs | ||
| } | ||
|
|
||
| type testEnv struct { |
Collaborator
There was a problem hiding this comment.
Is there a reason the testEnv is in env.go and not in a test file?
Contributor
Author
There was a problem hiding this comment.
It's because this gets used outside this package (NewTestEnv) for all the tests in tabletserver.
| db.AddQuery(q+" limit 10001", &sqltypes.Result{}) | ||
|
|
||
| _, _, err = tsv.BeginExecute(context.Background(), &target, q, nil, nil) | ||
| ctx := context.Background() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleanup improves readability where all the common parameters of tabletserver are unified under an interface tabletenv.Env. This will further facilitate componentization.