Skip to content

Improve error codes returned by tabletserver#6012

Merged
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:improve-some-error-codes
Apr 6, 2020
Merged

Improve error codes returned by tabletserver#6012
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:improve-some-error-codes

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented Apr 3, 2020

Desc

  • Small PR to improve some error codes returned by tabletserver. Per discussion with @sougou, it is clearer to return CANCELED when a query is killed. DeadlineExceeded, could be missleading.
  • Also noticed that we are not capturing correctly errors with code 1264. I added it to the list.

@rafael rafael requested a review from sougou as a code owner April 3, 2020 18:05
@rafael rafael force-pushed the improve-some-error-codes branch from 03c06e9 to 2f0d45c Compare April 4, 2020 02:26
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafael can you remove py-vtdb and vtgate binary from the PR?
We have deleted py-vtdb with the python->go test migration.

@rafael
Copy link
Copy Markdown
Member Author

rafael commented Apr 6, 2020

Oops - I added that accidentally after squashing commits.

Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael force-pushed the improve-some-error-codes branch from 2f0d45c to 8cc5f43 Compare April 6, 2020 19:01
@rafael
Copy link
Copy Markdown
Member Author

rafael commented Apr 6, 2020

@deepthi done 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants