Vreplication flaky test: make vcopier test non-flaky#6001
Merged
sougou merged 7 commits intovitessio:masterfrom Apr 3, 2020
Merged
Vreplication flaky test: make vcopier test non-flaky#6001sougou merged 7 commits intovitessio:masterfrom
sougou merged 7 commits intovitessio:masterfrom
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…e causing races since they continued to run Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…t times out Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Contributor
|
gofmt failed |
1 similar comment
Contributor
|
gofmt failed |
sougou
approved these changes
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy-catchup-fast-forward phases in the vreplication flow have different timeouts that determine how long a phase may last. This can result in extra transactions that update pos. The flakiness in vcopier_test.go was because we were incorrectly expecting a specific sequence of sql statements in a couple of tests.
Changing it to expect only the key sql statements and ignoring non-transaction queries has fixed the flakiness.
Additionally SecondsBehindMaster is now set correctly after the events are applied.