Merged
Conversation
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Contributor
Author
|
Waiting on #5944 and then I'll rebase. |
Signed-off-by: Morgan Tocker <tocker@gmail.com>
sougou
approved these changes
Mar 23, 2020
Member
|
I'm particularly looking forward to 1.14. Given how many places we're using
|
derekperkins
approved these changes
Mar 23, 2020
Member
derekperkins
left a comment
There was a problem hiding this comment.
No idea on the are you alive setup, but otherwise 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the minimum golang version to 1.13. For prior art, the PR to bump to 1.12 was #5017
There are a couple of differences:
I have also grepped for 1.12, and here is the result:
I have skipped the example 'are-you-alive' because it is a standalone example (and I have not tried testing it), but I am happy to include it if reviewers deem necessary.
Signed-off-by: Morgan Tocker tocker@gmail.com