Skip to content

add 'keyspace exist' check when ApplyVschema#5931

Merged
sougou merged 1 commit intovitessio:masterfrom
inolddays:checkkeyspaceifexistwhenapplyvschema
Mar 20, 2020
Merged

add 'keyspace exist' check when ApplyVschema#5931
sougou merged 1 commit intovitessio:masterfrom
inolddays:checkkeyspaceifexistwhenapplyvschema

Conversation

@inolddays
Copy link
Copy Markdown
Contributor

@inolddays inolddays commented Mar 17, 2020

Should also fix #5867

Signed-off-by: JohnnyThree whereshallyoube@gmail.com

@inolddays inolddays requested a review from sougou as a code owner March 17, 2020 10:48
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: s/initialed/initialized/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

Signed-off-by: JohnnyThree <whereshallyoube@gmail.com>
@inolddays inolddays force-pushed the checkkeyspaceifexistwhenapplyvschema branch from b2f438e to 7224d44 Compare March 17, 2020 14:58
@deepthi deepthi changed the title add 'keyspace exist' check when ApplyVshcema add 'keyspace exist' check when ApplyVschema Mar 17, 2020
@morgo morgo self-requested a review March 19, 2020 14:38
Copy link
Copy Markdown
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Applying VSchema referencing missing keyspace hides all keyspaces from UI

3 participants