vrepl: more documentation and fix stats#5905
Merged
deepthi merged 5 commits intovitessio:masterfrom Mar 10, 2020
Merged
Conversation
Also fix an incorrect test. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Not all code paths were updating the stats. This was causing the stats reported in /debug/status to be unreliable. This refactor keeps the stats and reporting in sync by performing the updates at the lower level functions that also update the vreplication table. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
approved these changes
Mar 9, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
LGTM, except for a few nits/typos and questions.
go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go
Outdated
Show resolved
Hide resolved
go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stats reporting was sometimes inaccurate. This change also fixes those issues.