Don't lower case keywords#5897
Conversation
|
This fixes #5821 |
harshit-gangal
left a comment
There was a problem hiding this comment.
LGTM
@sougou to confirm and merge.
Signed-off-by: Andres Taylor <andres@planetscale.com>
f11525b to
3f5196b
Compare
|
@systay I hate to suggest it - but you may need to add an option to temporarily revert the previous behavior. Apps that were built for Vitess may refer to columns in result sets in a case-sensitive way (they typically either do this or refer by ordinal position). We can say the option is deprecated on-launch and will be removed in a future version. The default behavior should be as in this PR. |
|
@morgo The issue of lower casing was only with non reserved vitess keywords. |
|
@harshit-gangal Sorry for my misunderstanding, that sounds better. Let's merge, and document as such. |
Before this change, non-reserved keywords would get their case changed when parsed.
was parsed as: