Merge Sharding tests in Go migrated from Python#5790
Merged
deepthi merged 5 commits intovitessio:masterfrom Feb 6, 2020
Merged
Merge Sharding tests in Go migrated from Python#5790deepthi merged 5 commits intovitessio:masterfrom
deepthi merged 5 commits intovitessio:masterfrom
Conversation
Contributor
ajeetj
commented
Feb 5, 2020
ajeetj
commented
- The base structure is copied from resharding test case
- Minor changes in base_sharding.go as we are comparing multiple values now
- updated config for merge sharding
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
ajeetj
force-pushed
the
tal_merge_sharding
branch
from
165cc39 to
e1b4096
Compare
deepthi
reviewed
Feb 6, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
A few nits. Otherwise looks good. I can approve once they are addressed.
|
|
||
| // TestV3MergeShardingString - tests merge sharding using a Byte column | ||
| func TestV3MergeShardingString(t *testing.T) { | ||
| sharding.TestMergesharding(t, true) |
Collaborator
There was a problem hiding this comment.
it will be nice to add /* useVarbinaryShardingKeyType */ before true.
Also why v3 in the name? v2 is no longer relevant, so we can remove that.
| shard2 = &cluster.Shard{Name: "80-"} | ||
|
|
||
| // merge shard | ||
| // merging -40 & 40-80 t0 -80 |
| ) | ||
|
|
||
| // TestV3MergeSharding - tests merge sharding using a INT column | ||
| func TestV3MergeSharding(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
same comment here. remove v3, add comment before boolean.
test/config.json
Outdated
| ] | ||
| }, | ||
| "merge_sharding": { | ||
| "File": "mergesharding_v3_test.go", |
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Contributor
Author
|
@deepthi Addressed review comments. Waiting for checks to pass. |
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
ajeetj
force-pushed
the
tal_merge_sharding
branch
from
867e40b to
85410f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.