populate local_metadata after agent has been initialized#5783
Merged
deepthi merged 2 commits intovitessio:masterfrom Feb 7, 2020
Merged
populate local_metadata after agent has been initialized#5783deepthi merged 2 commits intovitessio:masterfrom
deepthi merged 2 commits intovitessio:masterfrom
Conversation
deepthi
changed the title
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
force-pushed
the
ds-local-metadata
branch
from
97f356b to
e612098
Compare
enisoc
reviewed
Feb 4, 2020
…metadata Signed-off-by: deepthi <deepthi@planetscale.com>
Collaborator
Author
|
@enisoc ready for re-review. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5780.
Since
-restore_from_backuppopulates local_metadata regardless of the value of-init_populate_metadata, we decided to not make it a fatal error if both flags are set.Instead, the logic to populate local_metadata has been moved to the correct place (out of InitTablet) so that things work correctly if both flags are specified.
Note that we have chosen not to change the behavior of metadata_tables if
-init_populate_metadatais false in the presence of-restore_from_backupbecause doing so would break backwards compatibility.cc @guidoiaquinti
Signed-off-by: deepthi deepthi@planetscale.com