Skip to content

migrating mysqlctld python testcases to go#5774

Merged
deepthi merged 63 commits intovitessio:masterfrom
planetscale:backup-transform-mysqlctld
Feb 7, 2020
Merged

migrating mysqlctld python testcases to go#5774
deepthi merged 63 commits intovitessio:masterfrom
planetscale:backup-transform-mysqlctld

Conversation

@princeparmar
Copy link
Copy Markdown
Contributor

@princeparmar princeparmar commented Jan 30, 2020 •
edited
Loading

  1. created mysqlctld_process
  2. wrote mysqlctld basic testcases
  3. backup_mysqlctld testcase
  4. backup transform mysqlctld
  5. updated config.json

ajeetj and others added 30 commits January 20, 2020 10:32
@ajeetj
initial commit for backup_only
609f1d9 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
changes in package structure
a36ac69 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
updating package name and fixing a test
b64271b 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
removed unrequired teardown code
a8273a8 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
Removed debug code
975645f 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
inital commit for xtrabackup
1563e63 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
fix sequencing of cleanup
de23c53 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
fix terminate restore for xtrabackup
769d6f7 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
updated config for xtrabackup
621c848 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@princeparmar
backup-mysqlctld: mysqlctld setup module created.
cad5498 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@ajeetj
added xtrabackup stream mode
d556aa3 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
updated config for xtrabackup stream
7cd55aa 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
minor changes to config
502cacb 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
initial commit for backup_only
bdbc989 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
changes in package structure
ed44822 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
updating package name and fixing a test
366fe54 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
removed unrequired teardown code
f887be3 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
Removed debug code
29569e8 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
inital commit for xtrabackup
833cd08 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
fix sequencing of cleanup
7e9f837 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
fix terminate restore for xtrabackup
815b693 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
updated config for xtrabackup
61fe132 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
added xtrabackup stream mode
a334d24 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
updated config for xtrabackup stream
d68b6c4 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj @arindamnayak
minor changes to config
e10dbdb 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@arindamnayak
rebased to resolve conflict
c1e8706 
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
@princeparmar
backup-mysqlctld: mysqlctld health check changes.
4acd21e 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
Merge branch 'xtrabackup' into backup-mysqlctld
480d111 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup_mysqlctld: mysqlctld teardown fixes. vttablet restart method c…
640bc64 
…reated.

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup-mysqlctld: mysqlctld restart fixed, backup utils refactor.
1a99489 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
ajeetj
ajeetj reviewed Jan 30, 2020
View reviewed changes
@princeparmar
mysqlctld: review changes,
baca2f8 
code refactor, removed some functions.

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Jan 31, 2020

I didn't notice this earlier, but can backuptransform move inside backup (and then you can call it just transform). Similarly backuptransformmysqlctld is an awkward name. Can you move this also inside backup directory and rename with a shorter name?

@ajeetj
Copy link
Copy Markdown
Contributor

ajeetj commented Jan 31, 2020

I didn't notice this earlier, but can backuptransform move inside backup (and then you can call it just transform). Similarly backuptransformmysqlctld is an awkward name. Can you move this also inside backup directory and rename with a shorter name?

I was about to comment exactly that. :)

princeparmar and others added 6 commits January 31, 2020 10:23
@princeparmar
backup_transform: refator.
dbed929 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup_mysqlctld: config changes.
ac01391 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@ajeetj
restore vtBackup test
49189be 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
Merge branch 'backup-transform-mysqlctld' of github.com:planetscale/v…
a16bdeb 
…itess into backup-transform-mysqlctld

Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
redistribute travis tests
05ea4d4 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
updated shard matrix for transform test
4ef2a1f 
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@princeparmar princeparmar changed the title Backup transform mysqlctld migrating mysqlctld python testcases to go Jan 31, 2020
@princeparmar
mysqlctld: mysqlctld teardown issue resolved.
f8c103d 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
mysqlctld: mysqlctld teardown issue resolved.
4fa21f5 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
Merge branch 'backup-transform-mysqlctld' of https://github.com/plane…
0601bf8 
…tscale/vitess into backup-transform-mysqlctld

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
Merge branch 'backup-transform-mysqlctld' of https://github.com/plane…
db14fc2 
…tscale/vitess into backup-transform-mysqlctld

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
Merge branch 'backup-transform-mysqlctld' of https://github.com/plane…
346d66e 
…tscale/vitess into backup-transform-mysqlctld

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
Merge branch 'backup-transform-mysqlctld' of https://github.com/plane…
12a4a73 
…tscale/vitess into backup-transform-mysqlctld

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
Merge branch 'backup-transform-mysqlctld' of https://github.com/plane…
c2d3538 
…tscale/vitess into backup-transform-mysqlctld

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Feb 6, 2020

cluster_endtoend / build (14) is consistently hanging on this PR, that needs to be fixed.

deepthi
deepthi reviewed Feb 6, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good.
A few questions and suggestions inline.
The failing test still needs to be fixed.

go/test/endtoend/backup/mysqlctld/backup_mysqlctld_test.go

// TestBackupMysqlctld - tests the backup using mysqlctld.
func TestBackupMysqlctld(t *testing.T) {
backup.TestBackup(t, backup.Mysqlctld, "", 0)
Copy link
Copy Markdown
Collaborator

@deepthi deepthi Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comments to the parameters so that it is easier to understand what we are testing.

go/test/endtoend/cluster/topo_process.go Outdated
Copy link
Copy Markdown
Collaborator

@deepthi deepthi Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this causing problems?

go/test/endtoend/mysqlctld/mysqlctld_test.go Outdated
Copy link
Copy Markdown
Collaborator

@deepthi deepthi Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table -> tablet

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Feb 6, 2020

@ajeetj can you review the directory structure and file naming overall? since we are putting each test in a separate directory, it's not really necessary to repeat the directory names in the test file names.

@princeparmar
mysql-ctld: process teardown changes.
3b1e455 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar princeparmar force-pushed the backup-transform-mysqlctld branch from 713bafa to 3b1e455 Compare February 6, 2020 05:30
princeparmar and others added 3 commits February 6, 2020 13:34
@princeparmar
review changes and newConnection method modified.
6700a4f 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
mysqlctld: process hang issue resolved.
e17988d 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@deepthi
Merge branch 'master' into backup-transform-mysqlctld
202d66e
deepthi
deepthi approved these changes Feb 7, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 04471b2 into vitessio:master Feb 7, 2020
@deepthi deepthi deleted the backup-transform-mysqlctld branch February 7, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sougou sougou Awaiting requested review from sougou

2 more reviewers

@ajeetj ajeetj ajeetj left review comments

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@princeparmar @deepthi @ajeetj @arindamnayak